Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand single filename default allowed character set #400

Closed
iamogbz opened this issue Oct 30, 2020 · 0 comments · Fixed by #398
Closed

Expand single filename default allowed character set #400

iamogbz opened this issue Oct 30, 2020 · 0 comments · Fixed by #398
Labels
community Discussions or community related feature request New feature or request

Comments

@iamogbz
Copy link
Collaborator

iamogbz commented Oct 30, 2020

Description

Currently we support a limited character set for the default filenames in the single file extension.

Expanding the list would allow snapshot to use all the characters available to the file system without needing to override the internal method.

e.g.

test_parametrized_file[a].png instead of test_parametrized_filea.png

Source:
#398 (comment)_
@iamogbz iamogbz added community Discussions or community related feature request New feature or request labels Oct 30, 2020
@noahnu noahnu modified the milestone: v1.0.0 Oct 30, 2020
@iamogbz iamogbz mentioned this issue Nov 13, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community Discussions or community related feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: expand single filename legal characters syrupy-project/syrupy
2 participants
@noahnu @iamogbz