Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MSC3916 (without MSC3911) #509

Merged
merged 51 commits into from
Jul 3, 2024
Merged

Support MSC3916 (without MSC3911) #509

merged 51 commits into from
Jul 3, 2024

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Nov 25, 2023

MSC3911 adds complexity that shouldn't block this feature.

See matrix-org/matrix-spec-proposals#3916
See #465
Closes #103
Closes #266
Closes #118

TODO:

  • MSC3916 - Split endpoints into Client-Server and Federation APIs
  • MSC3916 - X-Matrix authentication on Federation APIs
  • MSC3916 - Access token authentication on Client-Server APIs
  • MSC3916 - multipart/mixed Content-Type on new /download and /thumbnail endpoints
  • MSC3916 - Use new endpoints to download media
  • MSC3916 - Tests

test/test_internals/util_client.go Dismissed Show dismissed Hide dismissed
@turt2live turt2live force-pushed the travis/msc3916-only branch 3 times, most recently from 5b49457 to 17a78d5 Compare May 25, 2024 00:33
@turt2live turt2live marked this pull request as ready for review May 29, 2024 23:30
matrix/server_discovery.go Fixed Show fixed Hide fixed
api/_routers/97-require-server-auth.go Fixed Show fixed Hide fixed
matrix/requests.go Fixed Show fixed Hide fixed
matrix/server_discovery.go Fixed Show fixed Hide fixed
@turt2live
Copy link
Member Author

I'm giving up trying to fix the tests here: #589

@turt2live turt2live merged commit 1c834ea into main Jul 3, 2024
4 of 5 checks passed
@turt2live turt2live deleted the travis/msc3916-only branch July 3, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MSC1902 Sign remote media requests Start implementation for media repo auth (MSC701)
1 participant