Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: name clashes with FunC keywords for struct constructor parameters #467

Merged

Conversation

anton-trunov
Copy link
Member

Closes #466

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov added this to the v1.4.1 milestone Jun 22, 2024
@anton-trunov anton-trunov requested a review from Gusarich June 22, 2024 17:41
@anton-trunov anton-trunov self-assigned this Jun 22, 2024
@novusnota
Copy link
Member

Cool, but seems like this ties us to FunC even more. Maintenance of the keyword list may bring occasional bugs in the future. I wonder if we could use different names, like prefixing things with underscores or even UUID's of sort?

@anton-trunov
Copy link
Member Author

anton-trunov commented Jun 23, 2024

Cool, but seems like this ties us to FunC even more.

No, it does not, it does quite the opposite. The test shows you can use all current FunC keywords as your struct field identifiers. And it's highly unlikely FunC will have keywords starting with $.

@anton-trunov anton-trunov merged commit a0b9685 into main Jun 24, 2024
3 checks passed
@anton-trunov anton-trunov deleted the fix-func-keyword-clashes-with-struct-constructor-params branch June 24, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Struct constructor parameters clash with FunC keywords
2 participants