fix(seeder): ensure SeederExecutor properly sorts seed files on fileName #642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seed files are expected to be run in
fileName
order, same as migrations.SeederExecutor.buildEntities
method in place uses thename
attribute (equal toclassName
) to sort files.Given the two files:
001-customers.seed.ts
, exporting aCustomersSeeder
class002-contracts.seed.ts, exporting a
ContractsSeeder` classAnd given that the
ContractsSeeder
tries to fetchCustomer
entities, theseed:run
command will fail when sorting seeds byclassName
.This pull request changes the sort call to use the
fileName
attribute instead.