Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glk banners are frequently closed and reopened #15

Open
curiousdannii opened this issue Jan 18, 2022 · 2 comments
Open

Glk banners are frequently closed and reopened #15

curiousdannii opened this issue Jan 18, 2022 · 2 comments
Labels

Comments

@curiousdannii
Copy link
Contributor

Glk banners are frequently closed and reopened when their content changes. For example, in menus, whenever you move the cursor, both windows are closed then reopened.

Is this behaviour directed from the TADS code? Ie, does the TADS menu delete then reopen all the banners? Or is it a quirk of this Glk implementation? I did notice that the os_banners_redraw function does close and reopen them all, so I think it's the latter.

@realnc
Copy link
Member

realnc commented Jan 18, 2022

I don't believe that the TADS side does that. If that were the case, it would invalidate scroll positions for scrollable banners.

@angstsmurf
Copy link
Contributor

I got the impression that it did this in order to update styles on-the-fly, changing the appearance of Glk styles with hints and make the new appearance reflect in the window. I never found an example where this was actually needed, though.

Perhaps somebody intended to use this to make the Glk port support more of the colours and styles of HTML TADS but never got round to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants