Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squash clear_list calls into one kernel? #915

Closed
k-ye opened this issue May 3, 2020 · 2 comments
Closed

Squash clear_list calls into one kernel? #915

k-ye opened this issue May 3, 2020 · 2 comments
Labels
discussion Welcome discussion! enhancement Make existing things or codebases better wontfix We won't fix this issue or merge this PR

Comments

@k-ye
Copy link
Member

k-ye commented May 3, 2020

Concisely describe the proposed feature

Right now, before launching a kernel that iterates over a sparse tensor, Taichi will generate a series of

clear_list(s1);
element_listgen(s1);
clear_list(s2);
element_listgen(s2);
...

@yuanming-hu I think we can have a single kernel for all the clear_list() calls along the tree?

This idea came from #896 , where the user has noticed a slower performance when using sparse tensors, due to the overhead. I don't think clear_list() is the major overhead here, but having as fewer kernels as possible might always be a good thing..

@k-ye k-ye added feature request Suggest an idea on this project discussion Welcome discussion! enhancement Make existing things or codebases better and removed feature request Suggest an idea on this project labels May 3, 2020
@yuanming-hu
Copy link
Member

Let me tell you a secret: after #742 we will have kernel fusion and this can be done automatically :-)

@k-ye
Copy link
Member Author

k-ye commented May 3, 2020

Haha great! 😆

@k-ye k-ye added the wontfix We won't fix this issue or merge this PR label May 3, 2020
@k-ye k-ye closed this as completed May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Welcome discussion! enhancement Make existing things or codebases better wontfix We won't fix this issue or merge this PR
Projects
None yet
Development

No branches or pull requests

2 participants