Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[error] Better error messages when using wrong type annotations #1612

Merged
merged 8 commits into from
Aug 4, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate commented Jul 30, 2020

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM in general. Could you add a few tests?

python/taichi/lang/impl.py Outdated Show resolved Hide resolved
python/taichi/lang/kernel.py Outdated Show resolved Hide resolved
python/taichi/lang/kernel.py Outdated Show resolved Hide resolved
python/taichi/lang/kernel.py Outdated Show resolved Hide resolved
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #1612 into master will increase coverage by 0.10%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1612      +/-   ##
==========================================
+ Coverage   45.00%   45.11%   +0.10%     
==========================================
  Files          40       40              
  Lines        5739     5757      +18     
  Branches     1002     1007       +5     
==========================================
+ Hits         2583     2597      +14     
- Misses       3002     3004       +2     
- Partials      154      156       +2     
Impacted Files Coverage Δ
python/taichi/lang/impl.py 65.70% <50.00%> (-0.39%) ⬇️
python/taichi/lang/kernel.py 69.45% <88.23%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81437d6...79a75e4. Read the comment docs.

@archibate archibate requested a review from yuanming-hu August 2, 2020 04:24
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests! All LGTM.

@yuanming-hu yuanming-hu changed the title [error] Better error message when using wrong type annotation [error] Better error messages when using wrong type annotation Aug 4, 2020
@yuanming-hu yuanming-hu changed the title [error] Better error messages when using wrong type annotation [error] Better error messages when using wrong type annotations Aug 4, 2020
@yuanming-hu yuanming-hu merged commit ac4a6f5 into taichi-dev:master Aug 4, 2020
@yuanming-hu yuanming-hu mentioned this pull request Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants