-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[error] Better error messages when using wrong type annotations #1612
[error] Better error messages when using wrong type annotations #1612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM in general. Could you add a few tests?
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1612 +/- ##
==========================================
+ Coverage 45.00% 45.11% +0.10%
==========================================
Files 40 40
Lines 5739 5757 +18
Branches 1002 1007 +5
==========================================
+ Hits 2583 2597 +14
- Misses 3002 3004 +2
- Partials 154 156 +2
Continue to review full report at Codecov.
|
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests! All LGTM.
Related issue = https://forum.taichi.graphics/t/runtimeerror-ir-cpp-get-attribute-293-attribute-dim-not-found/1045/4
[Click here for the format server]