Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] New FAQs added #5784

Merged
merged 5 commits into from
Aug 23, 2022
Merged

Conversation

Olinaaaloompa
Copy link
Contributor

Related issue = #

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit c1a24b7
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62ff025420c7ea0008856f0f
😎 Deploy Preview https://deploy-preview-5784--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@writinwaters writinwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
@writinwaters writinwaters self-requested a review August 16, 2022 09:16
Copy link
Contributor

@writinwaters writinwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@writinwaters
Copy link
Contributor

I'll leave the rest to @ailzhang

@Olinaaaloompa Olinaaaloompa requested review from FantasyVR, jim19930609 and yuanming-hu and removed request for ailzhang August 16, 2022 10:26
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some comments.

docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@FantasyVR FantasyVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jim19930609 jim19930609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
docs/lang/articles/faqs/faq.md Outdated Show resolved Hide resolved
Co-authored-by: Vissidarte-Herman <93570324+Vissidarte-Herman@users.noreply.github.com>
@writinwaters writinwaters merged commit 0359a48 into taichi-dev:master Aug 23, 2022
erizmr pushed a commit to erizmr/taichi that referenced this pull request Aug 23, 2022
* [Doc] New FAQs added

* Update changes

* Apply suggestions from code review

Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>

* Apply changes according to feedback

* Apply suggestions from code review

Co-authored-by: Vissidarte-Herman <93570324+Vissidarte-Herman@users.noreply.github.com>

Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
Co-authored-by: Vissidarte-Herman <93570324+Vissidarte-Herman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants