Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ir] Let the type of ExternalTensorExpression be an ndarray struct #8191

Merged
merged 5 commits into from
Jun 19, 2023
Merged

[ir] Let the type of ExternalTensorExpression be an ndarray struct #8191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c044da2
[ir] Let the type of ExternalTensorExpression be an ndarray struct
lin-hitonami Jun 15, 2023
9a89ba4
Update on "[ir] Let the type of ExternalTensorExpression be an ndarra…
lin-hitonami Jun 15, 2023
392b4c4
Update on "[ir] Let the type of ExternalTensorExpression be an ndarra…
lin-hitonami Jun 15, 2023
290d85b
Update on "[ir] Let the type of ExternalTensorExpression be an ndarra…
lin-hitonami Jun 16, 2023
23c9834
Update on "[ir] Let the type of ExternalTensorExpression be an ndarra…
lin-hitonami Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions taichi/ir/frontend_ir.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,7 @@ void InternalFuncCallExpression::flatten(FlattenContext *ctx) {
void ExternalTensorExpression::flatten(FlattenContext *ctx) {
auto type =
TypeFactory::get_instance().get_ndarray_struct_type(dt, ndim, needs_grad);
type = TypeFactory::get_instance().get_pointer_type((Type *)type);

auto ptr = Stmt::make<ArgLoadStmt>(arg_id, type, /*is_ptr=*/true,
/*create_load=*/false);
Expand Down
3 changes: 2 additions & 1 deletion taichi/ir/frontend_ir.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,8 @@ class ExternalTensorExpression : public Expression {
}

void type_check(const CompileConfig *config) override {
ret_type = dt;
ret_type = TypeFactory::get_instance().get_ndarray_struct_type(dt, ndim,
needs_grad);
ret_type.set_is_pointer(true);
config_ = config;
}
Expand Down