Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: Remove yanked crate #549

Closed
NobodyXu opened this issue Jun 20, 2024 · 5 comments
Closed

codegen: Remove yanked crate #549

NobodyXu opened this issue Jun 20, 2024 · 5 comments

Comments

@NobodyXu
Copy link
Collaborator

NobodyXu commented Jun 20, 2024

In the cronjob, we could check for yanked crates and remove them from this action.

@taiki-e
Copy link
Owner

taiki-e commented Jun 20, 2024

While yanked versions should not be selected in the latest and omitted versions (this is already implemented), I don't think they should be disallowed from being used when explicitly specified. As far as I know, cargo is also moving in that direction: rust-lang/cargo#13974

@NobodyXu
Copy link
Collaborator Author

Thanks, yeah I can understand that decision.

In that case, how about storing the yanked information in manifest, and then default to skip the yanked version, while allowing user to override that behavior?

@taiki-e
Copy link
Owner

taiki-e commented Jun 20, 2024

default to skip the yanked version

Unless you explicitly specify the full version (tool: <tool>@<major>.<minor>.<patch>), this is already the default.

@taiki-e
Copy link
Owner

taiki-e commented Jun 20, 2024

I think it is good to warn if the yanked version is explicitly selected, but I don't think we should change the version on our own.

@NobodyXu
Copy link
Collaborator Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants