PinnedDrop implementations can contain unsafe code without an unsafe block

[sfackler]

Since the #[pinned_drop] attribute injects an unsafe onto the drop fn, code within the drop implementation can perform unsafe operations without an explicit unsafe block.

You could potentially instead generate something like

impl PinnedDrop for Foo {
    unsafe fn drop(self: Pin<&mut Self>) {
        fn drop_inner(self: Pin<&mut Self>) {
            // user code here
        }
        drop_inner(self);
    }
}

[Aaron1011]

This is what my original PR did, for exactly this reason. It looks like this got changed at some point.

[taiki-e]

@sfackler Thanks for finding this! Seems I accidentally changed this in #86...
I will fix this soon.

[taiki-e]

Published 0.4.4 which fixes this issue.

[taiki-e]

(And yanked 0.4.0 - 0.4.3 which have this bug)

[sfackler]

Thanks!