feat(raiko): raiko object #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # host/src/execution.rs # host/src/preflight.rs
# Conflicts: # .github/workflows/ci.yml # README.md # host/src/execution.rs # host/src/preflight.rs # host/src/provider_db.rs # lib/src/utils.rs # provers/risc0/driver/src/bonsai.rs # rust-toolchain
# Conflicts: # rust-toolchain
CeciliaZ030
approved these changes
May 6, 2024
| }; | ||
|
|
||
| // Sanity check | ||
| if input.network.is_taiko() { | ||
| if input.chain_spec.is_taiko() { |
There was a problem hiding this comment.
Why do we still need is_taiko when assemble_protocol_instance only make sense if we're proving taiko?
There was a problem hiding this comment.
No real reason I think, just minimizing the differences between proving Ethereum and Taiko blocks. Perhaps for Ethereum blocks we can just not call assemble_protocol_instance at all which could also minimize the difference.
CeciliaZ030
added a commit
that referenced
this pull request
May 7, 2024
commit 56c46a8 Author: Roger <50648015+RogerLamTd@users.noreply.github.com> Date: Mon May 6 20:44:30 2024 -0700 update tooltip (#166) commit c4215bd Author: Brecht Devos <Brechtp.Devos@gmail.com> Date: Tue May 7 01:27:47 2024 +0200 feat(raiko): raiko object (#149) * Raiko object + update revm/alloy to reth versions * fix risc0 * fix risc0 ci * batch fetch block data * remove unnecessary box * fmt * update toolchains * fix risc0 * Fix compile issue * Fix build script not erroring out when a process encountered an error * Enable SP1 mock prover * fix fmt and compile error in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows raiko to be used in other programs as well. Also introduces a
BlockDataProvidertrait so that the block data is not required to come from an RPC node but can directly hook into a node database for example.This version of raiko can be imported in reth to prove blocks directly from within the node using reth's database. Useful for testing but also for real time proving of blocks.
Also should make it easier to set up tests. This PR contains two simple tests that actually fetches a block and proves it.
The host package should only contain the actual host stuff, the raiko stuff should move to a different package but to not unnecessarily make this PR very big with just moving stuff around, will do that in a follow up PR.