feat: prove blocks using reth #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.toml # host/src/preflight.rs # lib/src/protocol_instance.rs # provers/sp1/guest/elf/sp1-guest
# Conflicts: # Cargo.lock # Cargo.toml # core/src/lib.rs # core/src/preflight.rs # core/src/provider/db.rs # lib/Cargo.toml # lib/src/builder/execute.rs # lib/src/builder/finalize.rs # lib/src/builder/initialize.rs # lib/src/builder/mod.rs # lib/src/input.rs # lib/src/mem_db.rs # lib/src/protocol_instance.rs # provers/sp1/guest/elf/sp1-guest
Brechtpd
had a problem deploying
to
test-environment
GitHub Actions
Failure
Brechtpd
temporarily deployed
to
test-environment
GitHub Actions
Inactive
# Conflicts: # Cargo.lock # Cargo.toml # lib/Cargo.toml # lib/src/builder/execute.rs # lib/src/builder/finalize.rs # lib/src/builder/initialize.rs # lib/src/builder/mod.rs # lib/src/protocol_instance.rs # provers/risc0/guest/Cargo.lock # provers/risc0/guest/Cargo.toml # provers/risc0/guest/src/main.rs # provers/sp1/guest/Cargo.lock # provers/sp1/guest/Cargo.toml # provers/sp1/guest/elf/sp1-guest # provers/sp1/guest/src/main.rs # provers/sp1/guest/src/zk_op.rs
Brechtpd
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Brechtpd
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Brechtpd
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Brechtpd
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Brechtpd
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Brechtpd
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Brechtpd
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Brechtpd
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Brechtpd
temporarily deployed
to
test-environment
GitHub Actions
Inactive
|
lgtm |
smtmfft
approved these changes
Jun 25, 2024
Brechtpd
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Still necessary! https://github.com/taikoxyz/taiko-reth/blob/d20c700ca296f7e4227b4c8c254a8d0f948bbd36/crates/ethereum/evm/src/execute.rs#L222 |
Weird..is that a bug existed in both zeth & official reth?? I thought reth should be ok as its target is geth equivalence, should not have such a bug. |
|
Blocks don't skip invalid transactions on Ethereum, so the behavior we're triggering is taiko specific, so not a bug there. |
8 tasks
johntaiko
reviewed
Sep 13, 2024
| wallet.set_chain_id(Some(chain_id)); | ||
| println!("wallet: {:?}", wallet); | ||
|
|
||
| // init rpc conn | ||
| let http = Http::new(Url::parse(l1_rpc_url).expect("invalid rpc url")); | ||
| let provider = ProviderBuilder::new() | ||
| .with_recommended_fillers() | ||
| .signer(EthereumSigner::from(wallet.clone())) |
There was a problem hiding this comment.
Can't send transaction without this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reth v1.0.0-rc.2 taiko changes: taikoxyz/taiko-reth#6
revm v36 taiko changes: taikoxyz/revm#10