Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib,provers,tasks): move from sync to async trait #328

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(lib,provers,tasks): move from sync to async trait #328

merged 1 commit into from
Jul 23, 2024

Conversation

petarvujovic98
Copy link
Contributor

Fixes the issue of creating a runtime within a runtime by using async traits:

Issue sample:

thread 'tokio-runtime-worker' panicked at tasks/src/mem_db.rs:169:12:
Cannot start a runtime from within a runtime. This happens because a function (like `block_on`) attempted to block the current thread while the thread is being used to drive asynchronous tasks.
stack backtrace:

@petarvujovic98 petarvujovic98 self-assigned this Jul 23, 2024
@petarvujovic98 petarvujovic98 added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit 36a5614 Jul 23, 2024
14 checks passed
@petarvujovic98 petarvujovic98 deleted the db-access-fix branch July 23, 2024 09:54
@taiko-kitty taiko-kitty mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smtmfft smtmfft smtmfft approved these changes

Assignees

@petarvujovic98 petarvujovic98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petarvujovic98 @smtmfft