This repository has been archived by the owner on May 11, 2024. It is now read-only.
feat(prover): cancel proof if it becomes verified #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 53.86% 52.76% -1.11%
==========================================
Files 36 36
Lines 3193 3288 +95
==========================================
+ Hits 1720 1735 +15
- Misses 1248 1325 +77
- Partials 225 228 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Brechtpd
reviewed
May 3, 2023
davidtaikocha
approved these changes
May 5, 2023
vhjiang
pushed a commit
to taikoverse/taiko-degen-client
that referenced
this pull request
Jul 1, 2023
Co-authored-by: David <david@taiko.xyz>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also has a check to not submit a proof when its already verified, should solve both issues.
closes #202
@davidtaikocha im unsure if our client is capable of "proving" more than one block at a time, hence why I made a map. If it isn't, I can remove and just use the variable you have in place for last seen block id, or set s current proving block id.
Corresponding taiko-mono pr: taikoxyz/taiko-mono#13704