This repository has been archived by the owner on May 11, 2024. It is now read-only.
fix(flag): add a missing driver flag to configuration #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overall this looks like a good pull request. There are a few changes that should be considered:
CheckPointSyncUrlshould be renamed toCheckpointSyncURLfor consistency.- The value of
P2PSyncTimeouthas been changed from 600 to 1800. It would be helpful to provide a comment explaining why this change was made. - It would also be helpful to add a comment describing what the flag does in the
DriverFlagssection.
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 54.28% 54.00% -0.29%
==========================================
Files 36 36
Lines 3550 3550
==========================================
- Hits 1927 1917 -10
- Misses 1368 1379 +11
+ Partials 255 254 -1 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cyberhorsey
approved these changes
May 28, 2023
vhjiang
pushed a commit
to taikoverse/taiko-degen-client
that referenced
this pull request
Jul 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.