This repository has been archived by the owner on May 11, 2024. It is now read-only.
feat(driver): optimize error handling for CalldataSyncer
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #262 +/- ##
==========================================
+ Coverage 51.37% 51.97% +0.59%
==========================================
Files 36 36
Lines 3661 3654 -7
==========================================
+ Hits 1881 1899 +18
+ Misses 1532 1508 -24
+ Partials 248 247 -1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
davidtaikocha
added a commit
that referenced
this pull request
Jun 6, 2023
vhjiang
pushed a commit
to taikoverse/taiko-degen-client
that referenced
this pull request
Jul 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no "invalid block" in protocol, we need to retry the block insertion each time there is an error.
@cyberhorsey i force-merged this PR since i want to test it in our cluster asap, plz let me know if u find any issues in these changes :)