This repository has been archived by the owner on May 11, 2024. It is now read-only.
fix(prover): fix maxRetry configuration when submitting proofs
#364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 52.07% 52.48% +0.40%
==========================================
Files 35 35
Lines 4499 4502 +3
==========================================
+ Hits 2343 2363 +20
+ Misses 1893 1876 -17
Partials 263 263
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cyberhorsey
approved these changes
Aug 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not return an error when hitting the
maxRetry（--proofSubmissionMaxRetry） config, otherwise, it will still be retried by the main proof submission loop, and--proofSubmissionMaxRetryflag wont work: