This repository has been archived by the owner on May 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 332
feat(all): changes based on contestable zkRollup protocol design #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaikocha
force-pushed
the
contestable-zkrollup
branch
from
September 29, 2023 06:10
f32690b
to
b33d725
Compare
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
==========================================
+ Coverage 50.08% 53.94% +3.85%
==========================================
Files 39 44 +5
Lines 5043 5070 +27
==========================================
+ Hits 2526 2735 +209
+ Misses 2261 2061 -200
- Partials 256 274 +18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cyberhorsey
reviewed
Oct 12, 2023
@cyberhorsey pushed a new commit for changes based on the feedbacks, ready for review again: 01b7d37 |
RogerLamTd
reviewed
Oct 13, 2023
RogerLamTd
reviewed
Oct 13, 2023
RogerLamTd
reviewed
Oct 13, 2023
RogerLamTd
reviewed
Oct 13, 2023
RogerLamTd
reviewed
Oct 14, 2023
Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>
Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>
Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>
Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>
RogerLamTd
approved these changes
Oct 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--mode.contester
tempCapacity
)TODO:
proofProducer
when our SGX implementation and verification contract are readyzkevm-circuits
(maybe because there are too many transactions / some transactions have someaccessLists
/ some transactions are legacy transactions / ...), our guardian prover should sendkeccak256("RETURN_LIVENESS_BOND")
as proof.