fix(taiko_worker): fix a maxBytesPerTxList check issue
#282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mask-pp
approved these changes
Jul 2, 2024
dantaik
approved these changes
Jul 2, 2024
YoGhurt111
approved these changes
Jul 2, 2024
YoGhurt111
approved these changes
Jul 2, 2024
lwedge99
pushed a commit
to sentioxyz/taiko-geth
that referenced
this pull request
Jul 2, 2024
* fix(taiko_worker): fix a `maxBytesPerTxList` check issue * feat: more changes * feat: more changes
RogerLamTd
pushed a commit
that referenced
this pull request
Dec 11, 2024
* fix(taiko_worker): fix a `maxBytesPerTxList` check issue * feat: more changes * feat: more changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, think there may be an some double counting in your taiko_worker.go code when calculating if the total tx len is within the maxBytesPerTxList limit.
this check:
taiko-geth/miner/taiko_worker.go
Line 330 in 30a615b
However, if the transaction was successful it should have already been added to env.txs here:
taiko-geth/miner/worker.go
Line 764 in 30a615b
You will also run this check even if the tx failed and wasn't added to the tx list, which seems unecassary.
To fix I think you just need to move the maxBytesPerTxList check before committing the tx. Happy to PR this in if I haven't missed anything.