Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): Remove enableDestChain functionality #12341

Merged
merged 5 commits into from
Jan 10, 2023
Merged

Conversation

cyberhorsey
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #12341 (99d53f3) into main (b54a37e) will increase coverage by 0.10%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main   #12341      +/-   ##
==========================================
+ Coverage   67.68%   67.79%   +0.10%     
==========================================
  Files         109      109              
  Lines        2940     2934       -6     
  Branches      355      354       -1     
==========================================
- Hits         1990     1989       -1     
+ Misses        874      868       -6     
- Partials       76       77       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 95.05% <ø> (ø)
protocol 61.32% <42.85%> (+0.17%) ⬆️
relayer 69.10% <ø> (ø)
ui 100.00% <ø> (ø) Carriedforward from a15712b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/bridge-ui/src/constants/abi/Bridge.ts 100.00% <ø> (ø)
packages/protocol/contracts/L1/TaikoL1.sol 39.21% <0.00%> (ø)
...ckages/protocol/contracts/L1/libs/LibProposing.sol 4.83% <0.00%> (-0.25%) ⬇️
...s/protocol/contracts/bridge/libs/LibBridgeData.sol 100.00% <ø> (ø)
...l/contracts/test/bridge/libs/TestLibBridgeSend.sol 100.00% <ø> (+25.00%) ⬆️
packages/protocol/contracts/bridge/Bridge.sol 63.33% <100.00%> (-3.34%) ⬇️
...s/protocol/contracts/bridge/libs/LibBridgeSend.sol 100.00% <100.00%> (ø)
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (+7.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cyberhorsey cyberhorsey marked this pull request as draft January 10, 2023 04:54
@cyberhorsey cyberhorsey changed the title fix(protocol): Remove enableDestChain functionality fix(protocol): DRAFT: Remove enableDestChain functionality Jan 10, 2023
@cyberhorsey cyberhorsey changed the title fix(protocol): DRAFT: Remove enableDestChain functionality fix(protocol): Remove enableDestChain functionality Jan 10, 2023
@cyberhorsey cyberhorsey marked this pull request as ready for review January 10, 2023 05:25
@cyberhorsey cyberhorsey merged commit 362d083 into main Jan 10, 2023
@cyberhorsey cyberhorsey deleted the dest_chain_fix branch January 10, 2023 05:55
dantaik pushed a commit that referenced this pull request Jan 10, 2023
* rm enableDestChainid, fix tests, update ABIs

* fix taikol2 abi revert

* fix taiko l1 abi revert

* revert bridge abi

* enable dest chain in genesis tests
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants