fix(protocol): fix two protocol bugs #13034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberhorsey
requested review from
dantaik and
davidtaikocha
and removed request for
dantaik
Codecov Report
@@ Coverage Diff @@
## main #13034 +/- ##
==========================================
- Coverage 65.34% 65.27% -0.08%
==========================================
Files 113 113
Lines 3105 3104 -1
Branches 386 385 -1
==========================================
- Hits 2029 2026 -3
- Misses 999 1001 +2
Partials 77 77
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dantaik
requested changes
Jan 24, 2023
dantaik
previously approved these changes
Jan 24, 2023
dantaik
reviewed
Jan 24, 2023
dantaik
approved these changes
Jan 25, 2023
dantaik
changed the title
davidtaikocha
approved these changes
Jan 25, 2023
dantaik
requested review from
dionysuzx and
dantaik
and removed request for
RogerLamTd and
dionysuzx
dantaik
approved these changes
Jan 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction of
blockHashHistoryhas brokengetLatestSyncedHeader, which returns the zero address after the first iteration through blockHashHistory.verifyBlockspublc function max num blocks arg always verified 1 more than the block numbers specified. ie: passing in1verified2.