-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bridge-ui): add custom ERC20 tokens support #13170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #13170 +/- ##
==========================================
+ Coverage 60.11% 61.37% +1.26%
==========================================
Files 115 115
Lines 3450 3397 -53
Branches 468 439 -29
==========================================
+ Hits 2074 2085 +11
+ Misses 1289 1228 -61
+ Partials 87 84 -3
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shadab-taiko
requested review from
cyberhorsey,
dionysuzx,
dantaik,
davidtaikocha and
RogerLamTd
February 16, 2023 18:29
cyberhorsey
requested changes
Feb 16, 2023
cyberhorsey
requested changes
Feb 16, 2023
dantaik
approved these changes
Feb 23, 2023
dantaik
approved these changes
Feb 23, 2023
dantaik
changed the title
feat(bridge-ui): add custom ERC20 token support
feat(bridge-ui): add custom ERC20 tokens support
Feb 23, 2023
dantaik
requested review from
dantaik
and removed request for
dionysuzx and
RogerLamTd
February 23, 2023 03:21
dantaik
approved these changes
Feb 23, 2023
cyberhorsey
approved these changes
Feb 23, 2023
johntaiko
approved these changes
Feb 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #13153
Makes more required changes (majorly replacing
signal
withmsgHash
everywhere).Adds functionality to enable user to paste custom ERC20 address.
Addresses #12960 and #12977