fix(bridge-ui): pending transactions custom store with better error handling #13581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #13581 +/- ##
==========================================
+ Coverage 36.13% 36.58% +0.45%
==========================================
Files 124 126 +2
Lines 3778 3805 +27
Branches 502 504 +2
==========================================
+ Hits 1365 1392 +27
Misses 2321 2321
Partials 92 92
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jscriptcoder
requested review from
shadab-taiko,
cyberhorsey,
dionysuzx and
dantaik
cyberhorsey
approved these changes
Apr 18, 2023
dantaik
approved these changes
Apr 19, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the part around pending transaction list and added the logic into a custom store that exposes the
add()method, and takes care of removing the transaction when it's minded, resolving or rejecting depending on the status of the receipt. We were not informing the user of any failure for the transaction. This changes also fix thatTODO: Better error message, and maybe provide the user with a link to etherscan pointing to the failed transaction for more details.