Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relayer): Relayer reorg #14033

Merged
merged 2 commits into from
Jun 22, 2023
Merged

fix(relayer): Relayer reorg #14033

merged 2 commits into from
Jun 22, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Jun 22, 2023

Bad relayer logic resulted in deleted events from the database, because a MessageStatusChangedEvent with a same MsgHash would trigger a reorg detection for a MessageSent event, since they had the same MsgHash.

This will end up requiring a resync for both L1-L2 and L2-L1 relayer, and will result in transactions appearing missing from the bridge-ui as the relayer reindexes correctly, after being deployed.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #14033 (23c4695) into main (773331b) will decrease coverage by 0.28%.
The diff coverage is 27.50%.

@@            Coverage Diff             @@
##             main   #14033      +/-   ##
==========================================
- Coverage   51.99%   51.71%   -0.28%     
==========================================
  Files         147      148       +1     
  Lines        3829     3867      +38     
  Branches      336      336              
==========================================
+ Hits         1991     2000       +9     
- Misses       1728     1756      +28     
- Partials      110      111       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 94.23% <ø> (ø) Carriedforward from 146f8d5
eventindexer 74.49% <36.00%> (-3.53%) ⬇️ Carriedforward from 146f8d5
protocol 0.00% <ø> (ø) Carriedforward from 146f8d5
relayer 59.39% <13.33%> (-0.50%) ⬇️
ui 100.00% <ø> (ø) Carriedforward from 146f8d5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/eventindexer/repo/event.go 61.03% <0.00%> (-12.40%) ⬇️
packages/relayer/repo/event.go 73.25% <0.00%> (-10.75%) ⬇️
...ackages/relayer/indexer/detect_and_handle_reorg.go 33.33% <50.00%> (-5.13%) ⬇️
...ages/eventindexer/http/get_by_address_and_event.go 72.72% <72.72%> (ø)
packages/eventindexer/http/routes.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cyberhorsey cyberhorsey added this pull request to the merge queue Jun 22, 2023
Merged via the queue into main with commit 4794f45 Jun 22, 2023
@cyberhorsey cyberhorsey deleted the relayer_reorg branch June 22, 2023 09:22
@github-actions github-actions bot mentioned this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants