Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): use cards in guides #14378

Merged
merged 17 commits into from
Aug 11, 2023
Merged

feat(website): use cards in guides #14378

merged 17 commits into from
Aug 11, 2023

Conversation

2manslkh
Copy link
Contributor

@2manslkh 2manslkh commented Aug 4, 2023

No description provided.

dionysuzx
dionysuzx previously approved these changes Aug 4, 2023
dantaik
dantaik previously approved these changes Aug 4, 2023
Brechtpd and others added 7 commits August 8, 2023 09:20
Co-authored-by: David <david@taiko.xyz>
Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>
…14311)

Co-authored-by: David <david@taiko.xyz>
Co-authored-by: d1onys1us <13951458+d1onys1us@users.noreply.github.com>
…ing.mdx (#14390)

Co-authored-by: d1onys1us <13951458+d1onys1us@users.noreply.github.com>
Co-authored-by: d1onys1us <13951458+d1onys1us@users.noreply.github.com>
Co-authored-by: d1onys1us <13951458+d1onys1us@users.noreply.github.com>
@2manslkh 2manslkh enabled auto-merge August 8, 2023 02:25
dionysuzx
dionysuzx previously approved these changes Aug 8, 2023
Copy link
Contributor

@MarcusWentz MarcusWentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the emojis on the guides page and side tabs are changing inconsistently.

Please remove these changes and open a seperate PR for us to review.

dantaik
dantaik previously approved these changes Aug 11, 2023
@dantaik
Copy link
Contributor

dantaik commented Aug 11, 2023

@MarcusWentz @2manslkh This PR is getting old, could you guys work together to resolve pending feedbacks then review it again?

@dantaik dantaik removed the request for review from MarcusWentz August 11, 2023 09:21
@MarcusWentz MarcusWentz disabled auto-merge August 11, 2023 12:23
@MarcusWentz MarcusWentz enabled auto-merge August 11, 2023 12:23
@MarcusWentz MarcusWentz self-requested a review August 11, 2023 12:23
@MarcusWentz MarcusWentz added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit cd1db4a Aug 11, 2023
@MarcusWentz MarcusWentz deleted the docs-visuals branch August 11, 2023 12:24
@github-actions github-actions bot mentioned this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.