Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge): Token Vault sendEther messages with processing fees are impossible to send #277

Merged
merged 12 commits into from
Nov 18, 2022

Conversation

cyberhorsey
Copy link
Contributor

Closes #276

@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
website ⬜️ Ignored (Inspect) Nov 18, 2022 at 4:57AM (UTC)

@cyberhorsey cyberhorsey changed the title bug(bridge): Token Vault sendEther messages with processing fees are impossible to send fix(bridge): Token Vault sendEther messages with processing fees are impossible to send Nov 15, 2022
dantaik
dantaik previously approved these changes Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #277 (e78e02d) into main (ed6d551) will increase coverage by 16.63%.
The diff coverage is 100.00%.

❗ Current head e78e02d differs from pull request most recent head 2ebc836. Consider uploading reports for the commit 2ebc836 to get more accurate results

@@             Coverage Diff             @@
##             main     #277       +/-   ##
===========================================
+ Coverage   31.53%   48.16%   +16.63%     
===========================================
  Files          22       78       +56     
  Lines         964     2294     +1330     
  Branches        0      261      +261     
===========================================
+ Hits          304     1105      +801     
- Misses        644     1172      +528     
- Partials       16       17        +1     
Flag Coverage Δ
protocol 60.22% <100.00%> (?)
relayer 31.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/bridge/TokenVault.sol 26.08% <100.00%> (ø)
...ol/contracts/test/thirdparty/TestMessageSender.sol 100.00% <100.00%> (ø)
...s/protocol/contracts/test/libs/TestLib1559Math.sol 100.00% <0.00%> (ø)
...protocol/contracts/bridge/libs/LibBridgeSignal.sol 69.56% <0.00%> (ø)
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 83.13% <0.00%> (ø)
packages/protocol/contracts/bridge/Bridge.sol 66.66% <0.00%> (ø)
packages/protocol/contracts/L1/TaikoL1.sol 22.22% <0.00%> (ø)
...es/protocol/contracts/common/EssentialContract.sol 100.00% <0.00%> (ø)
...ckages/protocol/contracts/common/ConfigManager.sol 100.00% <0.00%> (ø)
...ages/protocol/contracts/common/AddressResolver.sol 68.42% <0.00%> (ø)
... and 47 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dantaik
dantaik previously approved these changes Nov 18, 2022
@cyberhorsey cyberhorsey merged commit 10d9bbc into main Nov 18, 2022
@cyberhorsey cyberhorsey deleted the token_vault_processing_fee_fix branch November 18, 2022 04:59
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bridge] bug - TokenVault unable to send message with processingFee > 0
3 participants