Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): expose getUncleProofDelay function #7058

Merged
merged 6 commits into from
Jan 4, 2023

Conversation

cyberhorsey
Copy link
Contributor

expose avgProofTime for block id so users of bridge can see expectation of when their L2 block which contains their transaction can roughly be expected

closes #421

…on of when their L2 block which contains their transaction can roughly be expected
@cyberhorsey cyberhorsey requested review from dantaik and davidtaikocha and removed request for dantaik January 3, 2023 15:50
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #7058 (f91f3a8) into main (dbf8db9) will increase coverage by 1.03%.
The diff coverage is 71.42%.

❗ Current head f91f3a8 differs from pull request most recent head db61121. Consider uploading reports for the commit db61121 to get more accurate results

@@            Coverage Diff             @@
##             main    #7058      +/-   ##
==========================================
+ Coverage   64.75%   65.79%   +1.03%     
==========================================
  Files         108      108              
  Lines        2925     2929       +4     
  Branches      355      355              
==========================================
+ Hits         1894     1927      +33     
+ Misses        955      926      -29     
  Partials       76       76              
Flag Coverage Δ *Carryforward flag
bridge-ui 95.05% <ø> (ø) Carriedforward from dbf8db9
protocol 57.36% <71.42%> (+2.07%) ⬆️
relayer 69.10% <ø> (ø) Carriedforward from dbf8db9
ui 100.00% <ø> (ø) Carriedforward from dbf8db9

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 13.33% <ø> (ø)
packages/protocol/contracts/L1/libs/LibUtils.sol 10.60% <60.00%> (+5.91%) ⬆️
packages/protocol/contracts/L1/TaikoL1.sol 25.49% <100.00%> (+3.04%) ⬆️
...ackages/protocol/contracts/test/L1/TestTaikoL1.sol 87.09% <0.00%> (+87.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

davidtaikocha
davidtaikocha previously approved these changes Jan 4, 2023
@vercel
Copy link

vercel bot commented Jan 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bridge-ui 🔄 Building (Inspect) Jan 4, 2023 at 2:38AM (UTC)

dantaik
dantaik previously approved these changes Jan 4, 2023
@dantaik dantaik changed the title feat(protocol): expose delay for blockid feat(protocol): expose getUncleProofDelay function Jan 4, 2023
@davidtaikocha davidtaikocha merged commit dd0f011 into main Jan 4, 2023
@davidtaikocha davidtaikocha deleted the expose_protocol_delay branch January 4, 2023 04:03
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jan 4, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Taiko Contributor:

GitPOAP: 2023 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(protocol): expose delay for block verification with view function
3 participants