-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bridge-ui): transaction tab same width as bridge width #8195
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8195 +/- ##
=======================================
Coverage 67.58% 67.58%
=======================================
Files 109 109
Lines 2934 2934
Branches 354 354
=======================================
Hits 1983 1983
Misses 875 875
Partials 76 76
*This pull request uses carry forward flags. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@shadab-taiko can we also make the min-height almost the same as the other tab? |
@wolfderechter This breaks once the transactions are populated. |
Looks terrible |
We can remove the two layer-icons from the table and change "Claimed" to a green check mark. |
@shadab-taiko you are right, I couldn't populate it locally but I think I fixed it. Do you know how I can populate locally? I think my .env isn't correct |
If "claim" means an action, it should look like a button or have a different color. |
I think I got it, I set the min-height to that of the bridge tab when there are 0 transactions. And I don't set a min-height when there are transactions so it stays fit-content. The min-width gets set based on the bridge width but the width increases to fit-content when there are transactions. Perhaps in another pull request the 'From and To' tab can be merged, my solution should still work when that happens. Let's hope my solution works in the testing environment as I'm not 100% sure. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LGTM |
@shadab-taiko could you please verify if everything works? |
Verified the transactions list with and without transactions. LGTM 🚀 . Thanks @wolfderechter |
The transacton tab now has the same width as the bridge tab as requested per #7730.