Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the kubernetes env, should we allow the score to change during an ADD op ? #47

Open
cezar-tech opened this issue Dec 26, 2023 · 1 comment

Comments

@cezar-tech
Copy link
Contributor

cezar-tech commented Dec 26, 2023

Regarding the kubernetes environment of deckard that connects to mongo and redis as storage and cache respectively, I was thinking that it might be useful to make the ADD operation more like an HTTP PUT im more ways, in this case I mean it to be able to change a message's score with an ADD operation, something that is currently not possible as I detail below.

In the mongo_storage.go file, we have the following code:

image

which result in the end in this following operation on mongo
image

And then we would probably need to change the redis (cache) script too
image

According to the docs, Redis also would support this:
image

@lucasoares
Copy link
Member

Do you think we should let users change the score on add requests or create a new gRPC request updateScore that is able to update the score if the message is on the queue?

Do you mind adding more details on the use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants