Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrier::tests::test_manage_retry_unreachable may randomly fail #226

Open
sr-gi opened this issue Jul 7, 2023 · 3 comments
Open

retrier::tests::test_manage_retry_unreachable may randomly fail #226

sr-gi opened this issue Jul 7, 2023 · 3 comments

Comments

@sr-gi
Copy link
Member

sr-gi commented Jul 7, 2023

I haven't seen retrier tests randomly failing much lately, but yesterday I got this one:

https://github.com/talaia-labs/rust-teos/actions/runs/5448919099/jobs/9979994482?pr=225

Tracking this to keep an eye on it.

@mariocynicys
Copy link
Collaborator

Another timing? failure but in retrier::tests::test_manage_retry_while_idle:
https://github.com/talaia-labs/rust-teos/actions/runs/5659276199/job/15332471299?pr=233

@sr-gi
Copy link
Member Author

sr-gi commented Jul 26, 2023

Looks like it. I hate timing-based tests :/

@orbitalturtle
Copy link
Contributor

Locally I've also been getting a test_manage_retry_while_idle failure, looks like at this line:

assert!(state.get_retrier_status(&tower_id).unwrap().is_idle());

Maybe it'd be worth doing a loop, trying the same call every second or so, either until it succeeds or times out (with a longer timeout than it currently has)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants