Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the too-long issue of header line #2

Closed
wants to merge 1 commit into from

Conversation

yuex
Copy link

@yuex yuex commented Sep 14, 2013

Hi, talha131, I tried your pelican theme elegant, it's awesome, clean and elegant.

But I find the header line of some pages is too long, e.g. archive.html, tags.html. "span10" makes sense for article.html, cause it needs to cover the side bar column. But it looks weird in archive.html, tags.html, categories.html, when there is no side bar. So I guess perhaps it's a bug?

@talha131
Copy link
Member

@yuex thank you for contributing to the project. No one appreciates it more than me. I should have responded earlier but last few days were crazy in my office. It took me more than a week to check my Github account.

"span10" makes sense for article.html, cause it needs to cover the side bar column

Yup, you are right. That's the reason I used span10 for articles.

But it looks weird in archive.html, tags.html, categories.html, when there is no side bar. So I guess perhaps it's a bug?

No it is intentional. I wanted to keep the look consistent. This is why categories, tags, archives and 404 page have span10.

I originally went with your idea during development. I realized although the change in length of the header line is subtle, it is jarring.

For the user, he is on the same site, he just clicked on a link. He doesn't care the link takes him to tags page or an article page. All he knows that by clicking he is following an internal link.

Now user's eye catch this subtle change. He feels something is out of place but doesn't know what it is. This effects reading comprehension. We want to UI to be consistent so that user's reading experience is not influenced by anything.

To be honest, I find both options to be evil. And I chose lesser evil of the two, for the sake of inhibited reading experience.

Still, please feel free to share ideas and patches.

@talha131 talha131 closed this Sep 25, 2013
@yuex
Copy link
Author

yuex commented Sep 26, 2013

Got it. But still, thanks for your kindly replay.

@talha131
Copy link
Member

@yuex My pleasure. By the way check this out, in case you haven't noticed already. 😃

talha131 referenced this pull request in talha131/elegant Jun 9, 2019
fixes #2 

I left a few instances where Talha’s homepage or profile is still used, where I thought it does not break anything and does not confuse the user.
talha131 referenced this pull request in talha131/elegant Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants