Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font colour is not set explicitly, rendering white text unreadable in dark mode #318

Open
bmarwell opened this issue Dec 1, 2020 · 7 comments

Comments

@bmarwell
Copy link
Contributor

bmarwell commented Dec 1, 2020

Expected Behavior

Font is readable even in dark mode.

Actual Behavior

When using a browser or IDE javadoc viewer in dark mode, the font is not readable as it is rendered in white.

Steps to Reproduce the Problem

  1. Switch your browser to forced dark mode
  2. Open generated docs via IDE or browser
  3. See white text (as text uses default colour) on yellowish background (as this is explicitly set).

Specifications

  • Version: all
  • Platform: any
  • Java version: any
  • (If open source) Project link: n/a
@sjoerdtalsma
Copy link
Contributor

@bmarwell Do you know of a way to define a .puml diagram with a color definition in such a way that the generated .svg image displays correctly in both regular and dark mode?

@bmarwell
Copy link
Contributor Author

bmarwell commented Dec 1, 2020

Hi, not really (I have not looked into it yet). But the box inner colour (bg colour) is fixed yellow, so a fixed black font should suffice.

@sjoerdtalsma
Copy link
Contributor

sjoerdtalsma commented Dec 2, 2020

Hi, not really (I have not looked into it yet). But the box inner colour (bg colour) is fixed yellow, so a fixed black font should suffice.

That sounds doable 😉 thanks for clarifying!

@sjoerdtalsma
Copy link
Contributor

@bmarwell, do you think you could test with the latest snapshot version whether this issue still persists?

I upgraded the PlantUML version and if I open the SVG images and change the background to #000000 (black), the image is still readable.

@sjoerdtalsma
Copy link
Contributor

sjoerdtalsma commented Aug 17, 2021

To use the snapshot from maven, make sure you enable the snapshot repository:

<repositories>
    <repository>
        <id>snapshots-repo</id>
        <url>https://oss.sonatype.org/content/repositories/snapshots</url>
        <releases><enabled>false</enabled></releases>
        <snapshots><enabled>true</enabled></snapshots>
    </repository>
</repositories>

Then you can change the 2.0.12 version of the doclet to 2.0.13-SNAPHOT to try it out.

@bmarwell
Copy link
Contributor Author

Hey @sjoerdtalsma, I currently do not maintain a project with PlantUML anymore 🙈
I might be able to apply it into a library soon, though. Sorry for the delay!

@sjoerdtalsma
Copy link
Contributor

No worries, I'll leave this issue open for a bit longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants