-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Docker Volumes for Configurable Error Pages #285
Comments
Hello there, Thank you for providing a detailed explanation of your issue! Currently, I'm working on a new major version of error-pages. Once the work is complete, I'll ping you here, and I hope you'll be pleasantly surprised by the new approach to handling custom templates 😉 |
Does this mean that this was kinda useless of me? https://github.com/Its4Nik/NGX-Error I added a custom github action that builds every theme there is and pushes it to ghcr.io |
¯\_ (ツ) _/¯ Even if you only found your solution useful - it makes sense, right? |
Yeah ig :) |
I could try to answer your question at #288 (comment) here
The error-pages project was designed to operate with error pages as single HTML pages, without loading additional resources from additional
Is it possible for you to embed the content of every |
Is there an existing issue for this?
Describe the problem to be solved
Currently, configuring error pages in Docker containers requires manual adjustments to the entrypoint script and ensuring proper permissions for mounted directories. Users need a streamlined way to mount volumes for error page templates, HTML, and configuration files, allowing easy customization and configuration without modifying the container's filesystem or rebuilding the image. Additionally, users should have shell access with docker exec to manage files if needed
Suggest a solution
Implement support for Docker volumes in the docker-entrypoint.sh script and Dockerfile to allow users to mount local directories to the container. This can be achieved by modifying the entrypoint script to handle symbolic links and permissions, and updating the Dockerfile to ensure proper setup. The following changes are suggested:
/config/templates
,/config/html
, and/config/error-pages.yml
are writable by the container user.Additional context
The following is a proposed Dockerfile and docker-entrypoint.sh script to support volume mounting and to support shell access:
dockerfile changes
dockerfile full output
docker-entrypoint.sh
Make sure to add docker-entrypoint.sh to the .dockerignore file
.dockerignore
By following this approach, users can mount volumes with the docker compose file:
docker-compose.yml
The text was updated successfully, but these errors were encountered: