Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call box.ctl.promote() on new leader #1372

Closed
R-omk opened this issue Apr 8, 2021 · 3 comments · Fixed by #2078
Closed

Call box.ctl.promote() on new leader #1372

R-omk opened this issue Apr 8, 2021 · 3 comments · Fixed by #2078
Labels
cartridge customer feature A new functionality
Milestone
2.8.0

Comments

@R-omk
Copy link
Contributor

R-omk commented Apr 8, 2021

The external algorithm of leader selection needs to take into account the specifics of synchronous replication.

tarantool/doc#1964
tarantool/tarantool#5435
@R-omk
Copy link
Contributor Author

R-omk commented Apr 8, 2021

related #1233

@R-omk R-omk changed the title Call box.ctl.clear_synchro_queue() on new leader Call box.ctl.promote() on new leader Apr 21, 2021
@sergos sergos added teamS Scaling feature A new functionality labels Sep 3, 2021
@rosik rosik added the cartridge label Sep 3, 2021
@filonenko-mikhail filonenko-mikhail added teamX and removed teamS Scaling labels Jan 12, 2022
@yngvar-antonsson yngvar-antonsson mentioned this issue Apr 12, 2022
Merged
3 tasks
@filonenko-mikhail filonenko-mikhail added this to the 2.8.0 milestone Apr 25, 2022
@yngvar-antonsson
Copy link
Collaborator

yngvar-antonsson commented May 17, 2022 •
edited
Loading

For the future development:

  • sync replication should work with any failover type
  • so we need to set election mode to manual it case of eventual/stateful failover and call box.ctl.promote on leader change
  • leader should have a largest vclock

@yngvar-antonsson yngvar-antonsson mentioned this issue Jun 30, 2022
Closed
@filonenko-mikhail filonenko-mikhail added 21sp and removed 8sp labels Jul 8, 2022
@filonenko-mikhail
Copy link
Contributor

The eventual failover is not compatible with box.ctl.promote()

@yngvar-antonsson yngvar-antonsson mentioned this issue Apr 19, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cartridge customer feature A new functionality
Projects
None yet
Milestone
2.8.0
Development

Successfully merging a pull request may close this issue.

Add box.ctl.promote call to stateful failover tarantool/cartridge
6 participants
@filonenko-mikhail @R-omk @rosik @olegrok @sergos @yngvar-antonsson