Allow to extract filename from http request body #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegrok
force-pushed
the
http-filename
branch
from
6e49667 to
03278f9
Compare
yngvar-antonsson
requested changes
Nov 18, 2021
test/unit/utils_test.lua
Outdated
| } | ||
| local payload, err, meta = utils.http_read_body(req) | ||
| t.assert_equals(payload, 'Content file') | ||
| t.assert_equals(err, nil) |
There was a problem hiding this comment.
Suggested change
| t.assert_equals(err, nil) | |
| t.assert_not(err) |
test/unit/utils_test.lua
Outdated
Comment on lines
40
to
44
| 'Content-Disposition: form-data; name="file"; filename="sample.txt"\r\n' .. | ||
| 'Content-Type: text/plain\r\n' .. | ||
| '\r\n' .. | ||
| 'Content file\r\n' .. | ||
| '--c187dde3e9318fcc6509f45f76a89424--' |
There was a problem hiding this comment.
Suggested change
| 'Content-Disposition: form-data; name="file"; filename="sample.txt"\r\n' .. | |
| 'Content-Type: text/plain\r\n' .. | |
| '\r\n' .. | |
| 'Content file\r\n' .. | |
| '--c187dde3e9318fcc6509f45f76a89424--' | |
| 'Content-Disposition: form-data; name="file"; filename="sample.txt"\r\n' .. | |
| 'Content-Type: text/plain\r\n' .. | |
| '\r\n' .. | |
| 'Content file\r\n' .. | |
| '--c187dde3e9318fcc6509f45f76a89424--' |
Steap2448
suggested changes
Nov 19, 2021
test/unit/utils_test.lua
Outdated
|
|
||
| function g.test_http_read_body() | ||
| local body = '--c187dde3e9318fcc6509f45f76a89424\r\n'.. | ||
| 'Content-Disposition: form-data; name="file"; filename="sample.txt"\r\n' .. |
There was a problem hiding this comment.
If I remember correctly, filename is an optional directive. Could you cover a case when there is none?
olegrok
force-pushed
the
http-filename
branch
from
03278f9 to
23ecdd9
Compare
This patch introduces the third argument for metadata of http request parsing (the second is reserved for an error). Before this patch function http_read_body returned only file content. However some of our customers want to know filename as well. It's not so hard to implement because body headers have such info and the main goal of this patch is to implement needed logic for header extraction.
olegrok
force-pushed
the
http-filename
branch
from
23ecdd9 to
de4b8c8
Compare
yngvar-antonsson
approved these changes
Nov 25, 2021
yngvar-antonsson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces the third argument for metadata of http
request parsing (the second is reserved for an error). Before this
patch function http_read_body returned only file content. However
some of our customers want to know filename as well. It's not so
hard to implement because body headers have such info and the main
goal of this patch is to implement needed logic for header
extraction.
Need for https://github.com/tarantool/tdg2/issues/1207