Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests fail on tarantool/master because of new error messages #1619

Closed
locker opened this issue Dec 1, 2021 · 2 comments · Fixed by #1647
Closed

Integration tests fail on tarantool/master because of new error messages #1619

locker opened this issue Dec 1, 2021 · 2 comments · Fixed by #1647
Assignees
Labels
testing Things to be covered with autotests

Comments

@locker
Copy link
Member

locker commented Dec 1, 2021

A few cartridge tests fail when run on tarantool/master:

Failed tests:

integration.ddl.test_no_instances_to_check_schema
integration.pool_map_call.test_errors_united
integration.pool_map_call.test_negative
integration.proxy.test_dead_destination
integration.rpc.test_api
integration.rpc.test_routing
integration.slow_requests.test_netbox_timeouts
integration.switchover.stateboard.test_all_rw
integration.switchover.stateboard.test_alone_instance
integration.switchover.stateboard.test_api
integration.switchover.stateboard.test_enabling
unit.remote_control.test_late_accept
unit.remote_control.test_reconnect
unit.remote_control.test_switch_box_to_rc

Error: Process completed with exit code 14.

The reason of the failure is that we slightly changed net.box error messages, see tarantool/tarantool#6653. Now, instead of Connection refused net.box will report something like connect, called on fd 55, aka 127.0.0.1:34138: Connection refused. This breaks the cartridge tests that expect an exact error message:

integration.ddl.test_no_instances_to_check_schema
...ad/src/tarantool/cartridge/test/integration/ddl_test.lua:270: Error message does not match pattern: "\"localhost:13301\":*Connection refused"
Error message received: "...ad/src/tarantool/cartridge/test/integration/ddl_test.lua:37: \"localhost:13301\": connect, called on fd 53, aka 127.0.0.1:56442: Connection refused"

Need to fix the tests to use pattern matching instead of exact string matching.

@yngvar-antonsson yngvar-antonsson added teamS Scaling testing Things to be covered with autotests labels Dec 2, 2021
@filonenko-mikhail filonenko-mikhail self-assigned this Dec 16, 2021
@filonenko-mikhail
Copy link
Contributor

1) integration.join_third_instance.test_join_third_storage
407
.../tarantool/test/integration/join_third_instance_test.lua:47: There is no active coordinator
408
stack traceback:
409
	...rk/tarantool/tarantool/cartridge/test-helpers/server.lua:194: in function 'graphql'
410
	.../tarantool/test/integration/join_third_instance_test.lua:47: in function 'integration.join_third_instance.test_join_third_storage'
411
	...tool/tarantool/.rocks/share/tarantool/luatest/runner.lua:344: in function <...tool/tarantool/.rocks/share/tarantool/luatest/runner.lua:343>
412
	[C]: in function 'xpcall'
413
	...tool/tarantool/.rocks/share/tarantool/luatest/runner.lua:343: in function 'super'
414
	...l/tarantool/.rocks/share/tarantool/luatest/capturing.lua:106: in function 'protected_call'
415
	...tool/tarantool/.rocks/share/tarantool/luatest/runner.lua:420: in function 'super'
416
	...ntool/tarantool/.rocks/share/tarantool/luatest/hooks.lua:175: in function 'invoke_test_function'
417
	...tool/tarantool/.rocks/share/tarantool/luatest/runner.lua:415: in function 'super'
418
	...
419
	[C]: in function 'xpcall'
420
	...ntool/tarantool/.rocks/share/tarantool/luatest/utils.lua:37: in function 'run_tests'
421
	...tool/tarantool/.rocks/share/tarantool/luatest/runner.lua:258: in function <...tool/tarantool/.rocks/share/tarantool/luatest/runner.lua:254>
422
	[C]: in function 'xpcall'
423
	...l/tarantool/.rocks/share/tarantool/luatest/capturing.lua:74: in function <...l/tarantool/.rocks/share/tarantool/luatest/capturing.lua:72>
424
	[C]: in function 'xpcall'
425
	...tool/tarantool/.rocks/share/tarantool/luatest/runner.lua:50: in function 'fn'
426
	...tool/.rocks/share/tarantool/luatest/sandboxed_runner.lua:14: in function 'run'
427
	...antool/.rocks/share/tarantool/luatest/cli_entrypoint.lua:4: in function <...antool/.rocks/share/tarantool/luatest/cli_entrypoint.lua:3>
428
	....rocks/share/tarantool/rocks/luatest/0.5.6-1/bin/luatest:3: in main chunk

@filonenko-mikhail
Copy link
Contributor

Tests fixed for tarantool 2.10
Every flucky tests opened in separate tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Things to be covered with autotests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants