From 8a8b557673fd2696b328083649dd92552fa7df22 Mon Sep 17 00:00:00 2001 From: Oleg Jukovec Date: Tue, 27 Dec 2022 13:36:31 +0300 Subject: [PATCH] ci: improve golangci-lint output After the patch golangci-lint prints a file and a line number [1]. 1. https://github.com/golangci/golangci-lint-action/issues/119 Closes #231 --- .github/workflows/check.yaml | 4 ++-- connector.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/check.yaml b/.github/workflows/check.yaml index d6a72e55b..dff140999 100644 --- a/.github/workflows/check.yaml +++ b/.github/workflows/check.yaml @@ -37,7 +37,7 @@ jobs: - uses: actions/checkout@v2 - name: golangci-lint - uses: golangci/golangci-lint-action@v2 + uses: golangci/golangci-lint-action@v3 with: # The suppression of the rule `errcheck` may be removed after adding # errors check in all methods calling EncodeXxx inside. @@ -47,7 +47,7 @@ jobs: # The `//nolint` workaround was not the acceptable way of warnings suppression, # cause those comments get rendered in documentation by godoc. # See https://github.com/tarantool/go-tarantool/pull/160#discussion_r858608221 - args: -E goimports -D errcheck + args: --out-${NO_FUTURE}format colored-line-number -E goimports -D errcheck codespell: runs-on: ubuntu-latest diff --git a/connector.go b/connector.go index d93c69ec8..f789ba326 100644 --- a/connector.go +++ b/connector.go @@ -11,7 +11,7 @@ type Connector interface { Select(space, index interface{}, offset, limit, iterator uint32, key interface{}) (resp *Response, err error) Insert(space interface{}, tuple interface{}) (resp *Response, err error) Replace(space interface{}, tuple interface{}) (resp *Response, err error) - Delete(space, index interface{}, key interface{}) (resp *Response, err error) + Delete(space, index interface{}, key interface{}) (resp *Response, err error) Update(space, index interface{}, key, ops interface{}) (resp *Response, err error) Upsert(space interface{}, tuple, ops interface{}) (resp *Response, err error) Call(functionName string, args interface{}) (resp *Response, err error)