Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upcoming PHP7 support #46

Closed
bigbes opened this issue Jun 1, 2015 · 9 comments
Closed

Add upcoming PHP7 support #46

bigbes opened this issue Jun 1, 2015 · 9 comments
Assignees
Labels
feature A new functionality in progress
Milestone

Comments

@bigbes
Copy link
Contributor

bigbes commented Jun 1, 2015

No description provided.

@bigbes bigbes added the feature A new functionality label Jun 1, 2015
@bigbes bigbes self-assigned this Jun 1, 2015
@bigbes bigbes added this to the 0.1.0 milestone Jun 2, 2015
@tony2001
Copy link
Contributor

tony2001 commented Mar 3, 2016

Here's my branch with PHP7 support: https://github.com/tony2001/tarantool-php/tree/php7_tnt16

@bigbes
Copy link
Contributor Author

bigbes commented Mar 3, 2016

@tony2001 Thank you, Tony! Is there anything we can do to merge your branch? To support both versions (PHP5 and PHP7).

@bigbes
Copy link
Contributor Author

bigbes commented Mar 11, 2016

Work in progress on branch php7-v1

@bigbes
Copy link
Contributor Author

bigbes commented Apr 11, 2016

First working version on branch php7-v1.
In the future, php7 driver would be rewritten with:

  1. pconnect branch
  2. tarantool-c driver

@bigbes bigbes assigned bigbes and unassigned bigbes Jun 23, 2016
@bigbes
Copy link
Contributor Author

bigbes commented Sep 6, 2016

Next working version on branch php7-v2.

@bigbes bigbes modified the milestones: 0.2.0, 0.1.0 Sep 22, 2016
@jobs-git
Copy link

Hi, what is the status for php7 support

@Totktonada
Copy link
Member

It is mostly done in the php7-v2 branch. I'll update it with fixes for PHP 7.3 (#139) and PHP 7.4 (#150), will enable packages building and deployment (#117) and after this will switch the branch php-7-v2 to master (#137).

This activity is tracked in #137 anyway, so I'll close this issue.

@jobs-git
Copy link

Hi, please dont remove branch for php 7.2, cause php 7.3 has some breaking changes. tnx!

@Totktonada
Copy link
Member

I'll add build-time conditions (similar to ones in PR #148), so the connector will build for php-7.{0-4}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality in progress
Projects
None yet
Development

No branches or pull requests

4 participants