-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create (and enforce) a TARDIS code style guide #1170
Comments
This will address #1094 |
Yeah, there are several style linters around ( |
Another thing that might be helpful is isort — just in the way of making things more automated. |
One way to do this would be to use a precommit hook: yt-project/yt#2600 |
Code style guide has been "create"ed in #1405 but we still need to work on "enforce"ing it by creating a black pre-commit hook! |
It's made possible by #1398, new PRs can't be merged unless code is formatted by black |
There should be a section of the documentation which describes TARDIS' code style conventions. This will help the code's readability and assist new contributors. The guide could cover
To enforce this, it would be helpful to automatically run a linter (e.g. flake8) on PRs which prints out any infringements of PEP 8 it finds. (Note some of PEP 8's suggestions are not always useful, so I suggest creating a
.flake8
file to list files and style conventions we'd like it to ignore)The text was updated successfully, but these errors were encountered: