From e6f6423cc77782487d6e3cd10cdbe441a7908198 Mon Sep 17 00:00:00 2001
From: "C.Lee Taylor" <47312074+leet4tari@users.noreply.github.com>
Date: Mon, 7 Feb 2022 18:44:48 +0200
Subject: [PATCH] ci: move Apple IDs into envs (#3797)

Description
Simple move Text into envs.

Motivation and Context
Future forks would not have tari ID's hard coded into GHA
---
 .github/workflows/base_node_binaries.yml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/base_node_binaries.yml b/.github/workflows/base_node_binaries.yml
index 805dd66d67..aec488f199 100644
--- a/.github/workflows/base_node_binaries.yml
+++ b/.github/workflows/base_node_binaries.yml
@@ -189,8 +189,10 @@ jobs:
         if: startsWith(runner.os,'macOS')
         env:
           MACOS_KEYCHAIN_PASS: ${{ secrets.MACOS_KEYCHAIN_PASS }}
+          MACOS_APPLICATION_ID: ${{ secrets.MACOS_APPLICATION_ID }}
           MACOS_APPLICATION_CERT: ${{ secrets.MACOS_APPLICATION_CERT }}
           MACOS_APPLICATION_PASS: ${{ secrets.MACOS_APPLICATION_PASS }}
+          MACOS_INSTALLER_ID: ${{ secrets.MACOS_INSTALLER_ID }}
           MACOS_INSTALLER_CERT: ${{ secrets.MACOS_INSTALLER_CERT }}
           MACOS_INSTALLER_PASS: ${{ secrets.MACOS_INSTALLER_PASS }}
         run: |
@@ -206,7 +208,7 @@ jobs:
           ./create_osx_install_zip.sh unused nozip
           FILES=("tari_base_node" "tari_console_wallet" "tari_mining_node" "tari_merge_mining_proxy")
           for FILE in "${FILES[@]}"; do
-            codesign --force -s "Developer ID Application: Tari Labs, LLC (8XGMD9X2H2)" "/tmp/tari_testnet/runtime/$FILE" -v
+            codesign --force -s "Developer ID Application: $MACOS_APPLICATION_ID" "/tmp/tari_testnet/runtime/$FILE" -v
             codesign --verify --deep --display --verbose=4 "/tmp/tari_testnet/runtime/$FILE"
           done
           pkgbuild --root /tmp/tari_testnet \
@@ -214,7 +216,7 @@ jobs:
           --version "$VERSION" \
           --install-location "/tmp/tari" \
           --scripts "/tmp/tari_testnet/scripts" \
-          --sign "Developer ID Installer: Tari Labs, LLC (8XGMD9X2H2)" \
+          --sign "Developer ID Installer: $MACOS_INSTALLER_ID" \
           "${{ github.workspace }}${{ env.TBN_DIST }}/tari-${{ env.VERSION }}.pkg"
       - name: Artifact macos pkg
         if: startsWith(runner.os,'macOS')