fix: fix console wallet tick events endless loop edge case at shutdown #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
previously approved these changes
Sep 22, 2021
Fixed an edge case with console wallet shutdown where the tick events send loop will continue to send key events after the receiver part of the channel has been closed.
hansieodendaal
force-pushed
the
ho_fix_console_wallet_shutting_down_endless_loop
branch
from
a312f95 to
298ca6f
Compare
stringhandler
approved these changes
Sep 28, 2021
hansieodendaal
deleted the
ho_fix_console_wallet_shutting_down_endless_loop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an edge case with console wallet shutdown where the tick events send loop will continue to send key or tick events after the receiver part of the channel has been closed. From the documentation: "A send operation can only fail if the receiving end of a channel is disconnected." The tick event sending loop is now exited if the receiver channel has been closed.
Motivation and Context
It was found with system-level testing that with shutdown some times multiple key or tick events are being sent on a closed receiver channel and prevents the wallet from shutting down cleanly.
How Has This Been Tested?
System-level testing.