fix: only allow one session per peer for block/header sync #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-block-sync-restrict-peer-sessions
branch
from
018607c to
9338fdf
Compare
Adds check for existing block sync sessions per peer.
sdbondi
force-pushed
the
core-block-sync-restrict-peer-sessions
branch
from
9338fdf to
505a223
Compare
stringhandler
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds check for existing block sync sessions per peer.
Improve logging
Motivation and Context
When shutting down my local node, I've observed many blksync rpc sessions for a single peer.
It is unclear why/how the peer is creating these sessions and keeping them up. I've attempted to recreate this
by constantly attempting a sync and then dropping the stream after it starts but RPC appeared to handle that correctly.
By forbidding this action for block sync, any client that misbehaves will get an error response and that should help
to narrow down where this issue originates.
How Has This Been Tested?
Manually.