refactor!: remove outdated wallet_ffi balance methods #3528
Conversation
StriderDM
force-pushed
the
wallet_ffi_remove_outdated_balance_methods
branch
from
36b3031 to
942020a
Compare
There was a problem hiding this comment.
So I see that the various Balance helper's exist but that the only way to get a balance after these methods are removed is via the callbacks. I think there still needs to be an explicit method to request the balance. So please include a wallet_get_balance(...) method in this PR that returns the current TariBalance.
The title of this breaking PR should have a ! in it to indicate it is a breaking change i.e. refactor!: remove outdated wallet_ffi balance methods
|
@philipr-za Your last comment with regards to |
StriderDM
force-pushed
the
wallet_ffi_remove_outdated_balance_methods
branch
2 times, most recently
from
41fd05f to
19e8fa8
Compare
StriderDM
changed the title
StriderDM
force-pushed
the
wallet_ffi_remove_outdated_balance_methods
branch
2 times, most recently
from
05139ea to
b57d586
Compare
StriderDM
force-pushed
the
wallet_ffi_remove_outdated_balance_methods
branch
2 times, most recently
from
606cd5b to
7af25fb
Compare
| @@ -321,6 +337,22 @@ class Wallet { | |||
| return result; | |||
| } | |||
|
|
|||
| getBalance() { | |||
There was a problem hiding this comment.
I think this method would be more aptly named getBalanceFromCallback() to minimize confusion
| return this.balance; | ||
| } | ||
|
|
||
| pollBalance() { |
There was a problem hiding this comment.
I think this method would be more aptly named getBalanceFromWallet() to minimize confusion (see related comment)
| pollBalance() { | ||
| return this.wallet.pollBalance(); |
There was a problem hiding this comment.
I think these methods would be more aptly named getBalanceFromWallet() to minimize confusion (see related comment)
StriderDM
dismissed stale reviews from hansieodendaal and philipr-za
via
a50bd5b
StriderDM
force-pushed
the
wallet_ffi_remove_outdated_balance_methods
branch
from
7af25fb to
a50bd5b
Compare
Removed outdated balance methods Updated wallet.h Updated cucumber tests Review comments cargo-fmt
StriderDM
force-pushed
the
wallet_ffi_remove_outdated_balance_methods
branch
from
a50bd5b to
35efa34
Compare
Description
Removed outdated balance methods in wallet_ffi
Updated wallet.h
Updated cucumber tests
Motivation and Context
Removal of outdated methods
Merge #3547 first.
How Has This Been Tested?
nvm use 12.22.6 && node_modules/.bin/cucumber-js --profile "ci" --tags "not @long-running and not @broken and @wallet-ffi"