fix: check for previously cancelled completed txn before accepting a repeat message #3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repeat When handling a potentially repeated inbound transaction message there was a check for previously cancelled PENDING transactions but this did not check for a previously cancelled completed transaction. This can occur if a transaction was completed and got rejected by the mempool. If this transaction exists then we should not add the pending transaction to our list. This PR updates the check for previously cancelled transactions to include completed transactions.
stringhandler
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When handling a potentially repeated inbound transaction message there was a check for previously cancelled PENDING transactions but this did not check for a previously cancelled completed transaction.
This can occur if a transaction was completed and got rejected by the mempool. If this transaction exists then we should not add the pending transaction to our list.
This PR updates the check for previously cancelled transactions to include completed transactions.
How Has This Been Tested?
cargo test