feat: add atomic swap htlc sending and claiming #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
force-pushed
the
sw_xtr_btc_swap
branch
2 times, most recently
from
e0a5b50 to
94ee0b5
Compare
philipr-za
reviewed
Nov 11, 2021
hansieodendaal
previously approved these changes
Nov 12, 2021
|
Changes look good, just needs a rebase. Quite a few conflicts. |
SWvheerden
force-pushed
the
sw_xtr_btc_swap
branch
3 times, most recently
from
bcbb904 to
db44ca8
Compare
SWvheerden
force-pushed
the
sw_xtr_btc_swap
branch
from
db44ca8 to
80ac4f6
Compare
philipr-za
approved these changes
Nov 16, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Nov 18, 2021
* development: (32 commits) feat: add atomic swap refund transaction handling (tari-project#3573) feat: improve wallet connectivity status for console wallet (tari-project#3577) v0.21.1 feat: add error codes to LibWallet for CipherSeed errors (tari-project#3578) ci: split cucumber job into two (tari-project#3583) feat(wallet): import utxo’s as EncumberedToBeReceived rather than Unspent (tari-project#3575) docs: rfc 0250_Covenants (tari-project#3574) feat: get fee for transactions for stratum transcoder (tari-project#3571) test: make monerod stagenet usage resilient (tari-project#3572) feat: add atomic swap htlc sending and claiming (tari-project#3552) feat: implement prometheus metrics for base node (tari-project#3563) feat: implement multiple read single write for sqlite (tari-project#3568) feat: trigger time lock balance update when block received (tari-project#3567) test: reduce cucumber ci to critical only (tari-project#3566) test: fix cucumber console wallet startup (tari-project#3564) chore: add node id/public key to log mdc (tari-project#3559) fix: avoid implicit using of the time crate (tari-project#3562) feat: one-click installer - cli edition (tari-project#3534) ci: add workflow dispatch to libwallet build action (tari-project#3556) fix: stop leak of value of recovered output (tari-project#3558) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pr adds in the ability to send and claim HTLC transactions.
This is added to the console wallet UI and GRPC commands.
UI:
tari_console_wallet --command "init-sha-atomic-swap <Amount> <Bob pubkey> <Message>"This is used to initialize an atomic swap for the XTR side
tari_console_wallet --command "finalise-sha-atomic-swap <Output hash> <pre_image hex>"This is used to finalize and claim an HTLC transaction for the XTR side.
GRPC:
rpc SendShaAtomicSwapTransaction(SendShaAtomicSwapRequest) returns (SendShaAtomicSwapResponse);This is used to initialize an atomic swap for the XTR side
rpc ClaimShaAtomicSwapTransaction(ClaimShaAtomicSwapRequest) returns (ClaimShaAtomicSwapResponse);This is used to finalize and claim an HTLC transaction for the XTR side.
Motivation and Context
This is the first step in allowing Atomic swaps for Tari and coins that have SHA256 as a pre_image.
Currently, the available commands in this PR and tools available we can do the happy path of an atomic swap for:
Bitcoin
Bitcoin Cash (Bitcoin ABC, Bitcoin Unlimited, Bitcoin XT)
Decred
Litecoin
Monacoin
Particl
Qtum
Vertcoin
Viacoin
Zcoin
How Has This Been Tested?
Added unit and cucumber tests for the Tari side.
Did a manual XTR BTC atomic swap
XTR UTXO hash:
186a95239d16ebf800cb3b7991521585b569253255002b009b16f11faab8d115BTC tx_ids:
1f770ce82aeb1f6c0d0345a6a88f1b3eb2e226595063491c93ad442625f678ae2b6e2e2566577e8e52da685e2abb4252b98fc4a60dc9a1b09a56e6b003900bc9