feat: prevent banning of connected base node in wallet #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
previously approved these changes
Dec 7, 2021
philipr-za
reviewed
Dec 7, 2021
StriderDM
force-pushed
the
console_wallet_prevent_banning_of_node
branch
from
9d58ed3 to
1abe5bb
Compare
StriderDM
force-pushed
the
console_wallet_prevent_banning_of_node
branch
from
1abe5bb to
c4c92a7
Compare
philipr-za
approved these changes
Dec 7, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Dec 8, 2021
* development: chore: add eslint to explorer (tari-project#3648) v0.22.0 perf: set MDB_NOLOCK for peer and blockchain database (tari-project#3473) feat: prevent banning of connected base node in wallet (tari-project#3642)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Dec 8, 2021
* development: chore: add eslint to explorer (tari-project#3648) v0.22.0 perf: set MDB_NOLOCK for peer and blockchain database (tari-project#3473) feat: prevent banning of connected base node in wallet (tari-project#3642)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR excludes the connected base node in the wallet from being banned.
Motivation and Context
Usability
How Has This Been Tested?
cargo test --all
nvm use 12.22.6 && node_modules/.bin/cucumber-js --profile "ci" --tags "not @long-running and not @broken"