feat!: add committee management utxo #3835
Conversation
delta1
added
the
W-consensus_breaking
applications/tari_collectibles/src-tauri/src/clients/wallet_client.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Happy, just would prefer a better name to committee_checkpoint. Checkpoint is used for the sidechain to checkpoint it's data to the base layer. Having two terms for checkpoint will probably be confusing.
I suggested committee_management but it's not great either. Open to other suggestions
delta1
removed
the
W-consensus_breaking
| @@ -17,7 +17,7 @@ pub enum OutputFeaturesVersion { | |||
|
|
|||
| impl OutputFeaturesVersion { | |||
| pub fn get_current_version() -> Self { | |||
| Self::V1 | |||
| Self::V0 | |||
There was a problem hiding this comment.
keep V0 for now until we opt in
| #[repr(u8)] | ||
| pub enum TransactionInputVersion { | ||
| V0 = 0, | ||
| V1 = 1, |
There was a problem hiding this comment.
This was added for testing and is unused for now
| @@ -196,7 +196,8 @@ impl UnblindedOutput { | |||
| )); | |||
| } | |||
| let commitment = factories.commitment.commit(&self.spending_key, &self.value.into()); | |||
| let output = TransactionOutput::new_current_version( | |||
| let output = TransactionOutput::new( | |||
| self.version.clone(), | |||
There was a problem hiding this comment.
I think this was a bug, as calling these functions would overwrite the given utxo version with whatever get_current_version would return
| @@ -242,7 +243,8 @@ impl UnblindedOutput { | |||
| .map_err(|_| TransactionError::RangeProofError(RangeProofError::ProofConstructionError))? | |||
| }; | |||
|
|
|||
| let output = TransactionOutput::new_current_version( | |||
| let output = TransactionOutput::new( | |||
| self.version.clone(), | |||
There was a problem hiding this comment.
I think this was a bug, as calling these functions would overwrite the given utxo version with whatever get_current_version would return
|
Just need to update some tests after the change back to V0 |
Description
bumps the output features version to V1 (this is a hard fork as older software won’t accept the new version)edit: keep V0 as current output features version and add mempool validation and consensus rules for versionstoo many argsto 12 and remove individualallowsupdate: 16 feb
specific changes: d34af75
current_versioninstead of the given utxo version