feat!: add less aggressive txn cancelling #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
force-pushed
the
ho_less_aggressive_txn_cancelling
branch
5 times, most recently
from
730924e to
9bf72fb
Compare
hansieodendaal
force-pushed
the
ho_less_aggressive_txn_cancelling
branch
from
9bf72fb to
035d7ee
Compare
hansieodendaal
changed the title
hansieodendaal
force-pushed
the
ho_less_aggressive_txn_cancelling
branch
from
035d7ee to
ee46b1f
Compare
philipr-za
reviewed
Mar 31, 2022
hansieodendaal
force-pushed
the
ho_less_aggressive_txn_cancelling
branch
2 times, most recently
from
f43b27b to
5f7989c
Compare
- Added less aggressive transaction cancelling when a wallet has difficulty discovering the receiving party (for direct P2P comms) or base node peers that could be used to send the transaction via store and forward. - Updated the wallet ffi with the new callbacks. - Added a cucuumber test to test sending transactions while offline.
hansieodendaal
force-pushed
the
ho_less_aggressive_txn_cancelling
branch
from
5f7989c to
7fc57c5
Compare
Yes, I added a special cucumber test to test the queueing as well. |
hansieodendaal
force-pushed
the
ho_less_aggressive_txn_cancelling
branch
from
7fc57c5 to
b996298
Compare
stringhandler
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users will now manually cancel transactions stuck in pending due to the wallet continuing to be being offline.
Note: Wallet ffi interface changed.
Motivation and Context
During a recent semi-stress test [report here] adverse connectivity and/or discovery symptoms caused ~55% of transactions to be abandoned. Attempted transactions should not be canceled if they failed to be sent both directly and via store and forward; a peer-to-peer connection may fail for valid reasons but failing to submit a transaction to a base node for store and forward delivery does not warrant the transaction to be canceled.
How Has This Been Tested?
System-level testing
Unit tests
Cucumber test:
Scenario: Wallet send transactions while offline