Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FeePerGramStats to ffi library #4114

Merged

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented May 18, 2022

Description

Add ffi function for getting the fee per gram stats.

How Has This Been Tested?

npm test -- -p none --name "As a client I want to get fee per gram stats"

@Cifko Cifko force-pushed the ffi-get-fee-estimates-per-block branch from 9931dd2 to b305d43 Compare May 18, 2022 19:06
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think there is a bug here thou.
Perhaps we should test that case on unit or integration tests

Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Just one require broken in cucumber code. With that fix, ran the new cucumber test and it passes.
Please also change the offset line to offset += last_count

base_layer/wallet_ffi/src/lib.rs Outdated Show resolved Hide resolved
integration_tests/helpers/ffi/feePerGramStats.js Outdated Show resolved Hide resolved
@Cifko Cifko force-pushed the ffi-get-fee-estimates-per-block branch from e0d14ac to ea74174 Compare May 19, 2022 08:23
@stringhandler stringhandler merged commit 234d32f into tari-project:development May 19, 2022
stringhandler pushed a commit that referenced this pull request May 20, 2022
Description
---
Add ffi function for getting the fee per gram stats.

How Has This Been Tested?
---
`npm test -- -p none --name "As a client I want to get fee per gram stats"`
@Cifko Cifko deleted the ffi-get-fee-estimates-per-block branch June 23, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants