-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add FeePerGramStats to ffi library #4114
feat: add FeePerGramStats to ffi library #4114
Conversation
9931dd2
to
b305d43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think there is a bug here thou.
Perhaps we should test that case on unit or integration tests
base_layer/core/src/mempool/unconfirmed_pool/unconfirmed_pool.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - Just one require
broken in cucumber code. With that fix, ran the new cucumber test and it passes.
Please also change the offset line to offset += last_count
e0d14ac
to
ea74174
Compare
Description --- Add ffi function for getting the fee per gram stats. How Has This Been Tested? --- `npm test -- -p none --name "As a client I want to get fee per gram stats"`
Description
Add ffi function for getting the fee per gram stats.
How Has This Been Tested?
npm test -- -p none --name "As a client I want to get fee per gram stats"